Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plates: Add Samples to Existing Plate Set #6202

Merged
merged 24 commits into from
Jan 16, 2025
Merged

Conversation

labkey-nicka
Copy link
Contributor

@labkey-nicka labkey-nicka commented Jan 8, 2025

Rationale

See https://github.com/LabKey/labkey-ui-premium/pull/640 for rationale.

Related Pull Requests

Changes

  • Update ArrayOperation to handle the following:
    • Processing existing plates
    • Filling existing wells
  • Consolidate handling in plate-createPlateSet.api endpoint. Stepping stone towards using the layout engine directly.
  • Rename PlateManager.getRunIdsUsingPlateInResults() to getRunCountUsingPlateInResults and just return the count.
  • Add a new implementation for gathering run counts for a collection of plates.
  • Add WellCount, WellsFilled, and WellsEmpty expression columns to the plate table.
  • Update LayoutOperation to optionally take source plates and flag support for filling existing wells.

Copy link
Contributor

@labkey-klum labkey-klum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I also pulled down the changes and did some manual testing, those also looked good.

@labkey-nicka labkey-nicka merged commit e5682e7 into develop Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants